Skip to content

update msquic for Ubuntu 22 #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 21, 2023
Merged

update msquic for Ubuntu 22 #808

merged 4 commits into from
Feb 21, 2023

Conversation

@wfurt
Copy link
Member

@wfurt wfurt commented Feb 21, 2023

This brings current msquic to both x64 & arm64.
We use OpenSSL 3 using UseSystemOpenSSLCrypto

Aside from that there are two more changes:

  • drop PowerShell and build directly using cmake
  • build and install package instead of file copy. That will hopefully make it closer to final production.

@wfurt wfurt self-assigned this Feb 21, 2023
@wfurt
Copy link
Member Author

wfurt commented Feb 21, 2023

BTW

helixbot@38871c2f2e04:/$ dpkg -L libmsquic
/.
/usr
/usr/share
/usr/share/doc
/usr/share/doc/libmsquic
/usr/share/doc/libmsquic/changelog.gz
/usr/lib
/usr/lib/x86_64-linux-gnu
/usr/lib/x86_64-linux-gnu/libmsquic.lttng.so.2.2.0
/usr/lib/x86_64-linux-gnu/libmsquic.so.2.2.0
/usr/lib/x86_64-linux-gnu/libmsquic.so.2

helixbot@38871c2f2e04:/$ ldd /usr/lib/x86_64-linux-gnu/libmsquic.so.2.2.0
	linux-vdso.so.1 (0x00007ffe27bdb000)
	libcrypto.so.3 => /lib/x86_64-linux-gnu/libcrypto.so.3 (0x00007fdbf6a8b000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fdbf6863000)
	/lib64/ld-linux-x86-64.so.2 (0x00007fdbf7035000)

ManickaP
ManickaP approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, otherwise LGTM. Thanks!

@wfurt wfurt merged commit 201ec14 into main Feb 21, 2023
@wfurt wfurt deleted the ubuntu22 branch February 21, 2023 17:38
This was referenced Feb 22, 2023
Closed
Closed
@wfurt
Copy link
Member Author

wfurt commented Mar 1, 2023

it seems like this was built as -staging but never made it to "production" @mthalman
Do we just need to rebuild the queue to get new tags?
Attempt to pull it to runtime looks good dotnet/runtime#82460

@wfurt
Copy link
Member Author

wfurt commented Mar 1, 2023

mariner image seems to have the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ManickaP ManickaP ManickaP approved these changes

@mthalman mthalman mthalman approved these changes

@CarnaViire CarnaViire Awaiting requested review from CarnaViire

Assignees

@wfurt wfurt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wfurt @ManickaP @mthalman